feat(native-filters): apply scoping of native filters to dashboard#12716
Merged
villebro merged 9 commits intoapache:masterfrom Jan 26, 2021
Merged
feat(native-filters): apply scoping of native filters to dashboard#12716villebro merged 9 commits intoapache:masterfrom
villebro merged 9 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12716 +/- ##
==========================================
- Coverage 66.73% 63.54% -3.20%
==========================================
Files 1021 488 -533
Lines 49967 30104 -19863
Branches 4890 0 -4890
==========================================
- Hits 33347 19130 -14217
+ Misses 16491 10974 -5517
+ Partials 129 0 -129
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
simcha90
changed the title
junlincc
added
the
dashboard:native-filters
Member
|
Thanks for the PRs of native dashboard filter, Simcha! 🙏 @agatapst please help review Simcha's PRs(this one and cross-filtering). Thanks! |
…_filters � Conflicts: � superset-frontend/spec/fixtures/mockNativeFilters.ts
villebro
reviewed
Jan 25, 2021
Member
villebro
left a comment
villebro
left a comment
There was a problem hiding this comment.
Superb stuff! First pass comments, but looks really nice and removes some ugly duct tape from Dashboard.jsx bringing this one step close to production grade 🎉
superset-frontend/spec/javascripts/dashboard/components/Dashboard_spec.jsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@villebro fixed notes |
Contributor
|
LGTM, nice work! |
agatapst
reviewed
Jan 25, 2021
villebro
approved these changes
Jan 26, 2021
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Jan 26, 2021
* master: (52 commits) docs: Updates to Superset Site for 1.0 (apache#12626) test(native-filters): scoping tree in native filters modal (apache#12655) Fix tests errors and warnings - iteration 3 (apache#12212) (apache#12219) Fix tests errors and warnings - iteration 5 (apache#12212) (apache#12224) Fix tests errors and warnings - iteration 6 (apache#12212) (apache#12227) feat(native-filters): apply scoping of native filters to dashboard (apache#12716) Fix tests errors and warnings - iteration 4 (apache#12212) (apache#12223) Fix tests errors and warnings - iteration 7 (apache#12212) (apache#12245) fix: missing select menu background (apache#12759) fix(explore): incorrect missing datasource condition (apache#12758) feat: default timepicker to last week when dataset is changed (apache#12609) feat(explore): allow opening charts with missing dataset (apache#12705) chore: upgrade Cypress to 6.2.1 (apache#12605) refactor(explore): Enhance Dataset and Control panel Collapse components (apache#12218) feat: Adding option to set_database_uri CLI command (apache#12740) docs: Fixed typo on line 348 (apache#12739) Fix tests errors and warnings - iteration 2 (apache#12212) (apache#12214) docs: Remove gatsby-plugin-offline (apache#12693) test: oracle engine spec (apache#12615) test: hive db engine spec (apache#12520) ...
This was referenced Mar 11, 2024
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR apply scoping of native filters on dashboard charts according next rules:
filter_boxlogic to reload appropriate chartsBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-01-24.at.16.30.59.mov
TEST PLAN
ADDITIONAL INFORMATION